Messages in this thread Patch in this message | | | From | Chenggang Qin <> | Subject | [PATCH 2/3] perf core: Fix a mmap & munmap mismatches bug in dso__load | Date | Fri, 11 Oct 2013 08:27:58 +0800 |
| |
From: Chenggang Qin <chenggang.qcg@taobao.com>
Some dsos' symsrc is neither syms_ss or runtime_ss. In this situation, the corresponding ELF file is opened and mmapped in symsrc__init(), but they will be not closed and munmapped in any place. This bug can lead to mmap & munmap mismatched, the mmap areas will exist during the life of perf. We can think this is a memory leak. This patch fixed the bug. symsrc__destroy() is called while the opened and mmaped ELF file has neither symtlb section nor dynsym section, and opdsec section. Thanks.
Cc: David Ahern <dsahern@gmail.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Yanmin Zhang <yanmin.zhang@intel.com> Cc: Wu Fengguang <fengguang.wu@intel.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Chenggang Qin <chenggang.qcg@taobao.com> Acked-by: Namhyung Kim <namhyung@kernel.org>
--- tools/perf/util/symbol.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index d5528e1..9675866 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -828,7 +828,8 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) if (syms_ss && runtime_ss) break; - } + } else + symsrc__destroy(ss); } -- 1.7.8.rc2.5.g815b
| |