Messages in this thread | | | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 34/34] mm: dynamically allocate page->ptl if it cannot be embedded to struct page | Date | Thu, 10 Oct 2013 23:09:21 +0300 (EEST) |
| |
Christoph Lameter wrote: > On Thu, 10 Oct 2013, Kirill A. Shutemov wrote: > > > +static inline bool ptlock_alloc(struct page *page) > > +{ > > + if (sizeof(spinlock_t) > sizeof(page->ptl)) > > + return __ptlock_alloc(page); > > + return true; > > +} > > Could you make the check a CONFIG option? CONFIG_PTLOCK_DOES_NOT_FIT_IN_PAGE_STRUCT or > so?
No. We will have to track what affects sizeof(spinlock_t) manually. Not a fun and error prune.
C sucks. ;)
-- Kirill A. Shutemov
| |