Messages in this thread | | | Date | Thu, 10 Oct 2013 08:24:19 +0200 | From | Michal Simek <> | Subject | Re: [PATCH v2 2/3] video: xilinxfb: Use devm_kzalloc instead of kzalloc |
| |
On 10/09/2013 05:13 PM, Joe Perches wrote: > On Wed, 2013-10-09 at 12:52 +0200, Michal Simek wrote: >> Simplify driver probe and release function. > [] >> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c > [] >> @@ -423,7 +419,7 @@ static int xilinxfb_of_probe(struct platform_device *pdev) >> pdata = xilinx_fb_default_pdata; >> >> /* Allocate the driver data region */ >> - drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL); >> + drvdata = devm_kzalloc(&pdev->dev, sizeof(*drvdata), GFP_KERNEL); >> if (!drvdata) { >> dev_err(&pdev->dev, "Couldn't allocate device private record\n"); > > Be nice to remove the unnecessary OOM message. > There's already a generic dump_stack on OOM.
Ah yeah - this series was made before I knew this. Will send v3.
Thanks, Michal
-- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[unhandled content-type:application/pgp-signature] | |