Messages in this thread | | | Date | Thu, 10 Oct 2013 01:15:34 -0500 | From | Rob Landley <> | Subject | Re: [PATCH] Squashfs: Refactor decompressor interface and code |
| |
On 10/07/2013 09:14:10 PM, Phillip Lougher wrote: > The decompressor interface and code was written from > the point of view of single-threaded operation. In doing > so it mixed a lot of single-threaded implementation specific > aspects into the decompressor code and elsewhere which makes it > difficult to seamlessly support multiple different decompressor > implementations. ... > 11 files changed, 237 insertions(+), 136 deletions(-)
It sounds like this is mostly refactoring, but it adds 100 lines of code? Let's see, new function prototypes in the header, new #includes in the added C file...
Ah, here's the biggest chunk: a new instance of the FSF boilerplate telling you to go to 51 Franklin Street to pick up a physical copy of GPLv3 and try to figure out how it's relevant to Linux:
> --- /dev/null > +++ b/fs/squashfs/decompressor_single.c > @@ -0,0 +1,107 @@ > +/* > + * Squashfs - a compressed read only filesystem for Linux > + * > + * Copyright (c) 2013 > + * Phillip Lougher <phillip@squashfs.org.uk> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2, > + * or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA > 02110-1301, USA. > + * > + * decompressor_single.c > + */
*shrug* Mostly just curious...
Rob
| |