lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sysfs/bin: Fix size handling overflow for bin_attribute
On Thu, Oct 10, 2013 at 10:38:47AM -0700, Greg KH wrote:
> On Thu, Oct 10, 2013 at 06:03:55PM +1100, Benjamin Herrenschmidt wrote:
> > While looking at the code, I noticed that bin_attribute read() and write()
> > ops copy the inode size into an int for futher comparisons.
> >
> > Some bin_attributes can be fairly large. For example, pci creates some for
> > BARs set to the BAR size and giant BARs are around the corner, so this is
> > going to break something somewhere eventually.
> >
> > Let's use the right type.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> This file (fs/sysfs/bin.c) is no longer in linux-next as Tejun merged it
> with the other file handling code in sysfs, to remove a bunch of
> duplicated logic.
>
> So, could you look at linux-next and see if this is still an issue there
> or not?

Ah, nevermind, I just looked, and it still is an issue there, I'll
hand-edit the patch to apply properly, thanks.

greg k-h


\
 
 \ /
  Last update: 2013-10-10 20:01    [W:0.041 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site