lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 078/104] ASoC: max98095: a couple array underflows
    Date
    3.8.13.11 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit f8d7b13e14357ed19d2ca2799539600418dc3939 upstream.

    The ->put() function are called from snd_ctl_elem_write() with user
    supplied data. The limit checks here could underflow leading to a
    crash.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Mark Brown <broonie@linaro.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    sound/soc/codecs/max98095.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c
    index 41cdd16..8dbcacd 100644
    --- a/sound/soc/codecs/max98095.c
    +++ b/sound/soc/codecs/max98095.c
    @@ -1863,7 +1863,7 @@ static int max98095_put_eq_enum(struct snd_kcontrol *kcontrol,
    struct max98095_pdata *pdata = max98095->pdata;
    int channel = max98095_get_eq_channel(kcontrol->id.name);
    struct max98095_cdata *cdata;
    - int sel = ucontrol->value.integer.value[0];
    + unsigned int sel = ucontrol->value.integer.value[0];
    struct max98095_eq_cfg *coef_set;
    int fs, best, best_val, i;
    int regmask, regsave;
    @@ -2016,7 +2016,7 @@ static int max98095_put_bq_enum(struct snd_kcontrol *kcontrol,
    struct max98095_pdata *pdata = max98095->pdata;
    int channel = max98095_get_bq_channel(codec, kcontrol->id.name);
    struct max98095_cdata *cdata;
    - int sel = ucontrol->value.integer.value[0];
    + unsigned int sel = ucontrol->value.integer.value[0];
    struct max98095_biquad_cfg *coef_set;
    int fs, best, best_val, i;
    int regmask, regsave;
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-10-10 19:01    [W:4.044 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site