lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 045/104] drm/radeon: fix panel scaling with eDP and LVDS bridges
    Date
    3.8.13.11 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alex Deucher <alexander.deucher@amd.com>

    commit 855f5f1d882a34e4e9dd27b299737cd3508a5624 upstream.

    We were using the wrong set_properly callback so we always
    ended up with Full scaling even if something else (Center or
    Full aspect) was selected.

    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/gpu/drm/radeon/radeon_connectors.c | 34 +++++++++++++++++++++++++++---
    1 file changed, 31 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
    index 2399f25..5a87c9f 100644
    --- a/drivers/gpu/drm/radeon/radeon_connectors.c
    +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
    @@ -1489,6 +1489,24 @@ static const struct drm_connector_funcs radeon_dp_connector_funcs = {
    .force = radeon_dvi_force,
    };

    +static const struct drm_connector_funcs radeon_edp_connector_funcs = {
    + .dpms = drm_helper_connector_dpms,
    + .detect = radeon_dp_detect,
    + .fill_modes = drm_helper_probe_single_connector_modes,
    + .set_property = radeon_lvds_set_property,
    + .destroy = radeon_dp_connector_destroy,
    + .force = radeon_dvi_force,
    +};
    +
    +static const struct drm_connector_funcs radeon_lvds_bridge_connector_funcs = {
    + .dpms = drm_helper_connector_dpms,
    + .detect = radeon_dp_detect,
    + .fill_modes = drm_helper_probe_single_connector_modes,
    + .set_property = radeon_lvds_set_property,
    + .destroy = radeon_dp_connector_destroy,
    + .force = radeon_dvi_force,
    +};
    +
    void
    radeon_add_atom_connector(struct drm_device *dev,
    uint32_t connector_id,
    @@ -1580,8 +1598,6 @@ radeon_add_atom_connector(struct drm_device *dev,
    goto failed;
    radeon_dig_connector->igp_lane_info = igp_lane_info;
    radeon_connector->con_priv = radeon_dig_connector;
    - drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type);
    - drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
    if (i2c_bus->valid) {
    /* add DP i2c bus */
    if (connector_type == DRM_MODE_CONNECTOR_eDP)
    @@ -1598,6 +1614,10 @@ radeon_add_atom_connector(struct drm_device *dev,
    case DRM_MODE_CONNECTOR_VGA:
    case DRM_MODE_CONNECTOR_DVIA:
    default:
    + drm_connector_init(dev, &radeon_connector->base,
    + &radeon_dp_connector_funcs, connector_type);
    + drm_connector_helper_add(&radeon_connector->base,
    + &radeon_dp_connector_helper_funcs);
    connector->interlace_allowed = true;
    connector->doublescan_allowed = true;
    radeon_connector->dac_load_detect = true;
    @@ -1610,6 +1630,10 @@ radeon_add_atom_connector(struct drm_device *dev,
    case DRM_MODE_CONNECTOR_HDMIA:
    case DRM_MODE_CONNECTOR_HDMIB:
    case DRM_MODE_CONNECTOR_DisplayPort:
    + drm_connector_init(dev, &radeon_connector->base,
    + &radeon_dp_connector_funcs, connector_type);
    + drm_connector_helper_add(&radeon_connector->base,
    + &radeon_dp_connector_helper_funcs);
    drm_object_attach_property(&radeon_connector->base.base,
    rdev->mode_info.underscan_property,
    UNDERSCAN_OFF);
    @@ -1634,6 +1658,10 @@ radeon_add_atom_connector(struct drm_device *dev,
    break;
    case DRM_MODE_CONNECTOR_LVDS:
    case DRM_MODE_CONNECTOR_eDP:
    + drm_connector_init(dev, &radeon_connector->base,
    + &radeon_lvds_bridge_connector_funcs, connector_type);
    + drm_connector_helper_add(&radeon_connector->base,
    + &radeon_dp_connector_helper_funcs);
    drm_object_attach_property(&radeon_connector->base.base,
    dev->mode_config.scaling_mode_property,
    DRM_MODE_SCALE_FULLSCREEN);
    @@ -1797,7 +1825,7 @@ radeon_add_atom_connector(struct drm_device *dev,
    goto failed;
    radeon_dig_connector->igp_lane_info = igp_lane_info;
    radeon_connector->con_priv = radeon_dig_connector;
    - drm_connector_init(dev, &radeon_connector->base, &radeon_dp_connector_funcs, connector_type);
    + drm_connector_init(dev, &radeon_connector->base, &radeon_edp_connector_funcs, connector_type);
    drm_connector_helper_add(&radeon_connector->base, &radeon_dp_connector_helper_funcs);
    if (i2c_bus->valid) {
    /* add DP i2c bus */
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-10-10 18:41    [W:4.315 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site