Messages in this thread | | | Date | Thu, 10 Oct 2013 10:44:39 +0100 | From | Will Deacon <> | Subject | Re: [PATCH v8 02/17] arm64: define DMA_ERROR_CODE |
| |
On Wed, Oct 09, 2013 at 09:48:15PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > Acked-by: Catalin Marinas <catalin.marinas@arm.com> > CC: will.deacon@arm.com > --- > arch/arm64/include/asm/dma-mapping.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/include/asm/dma-mapping.h b/arch/arm64/include/asm/dma-mapping.h > index 8d18100..c2cb8a0 100644 > --- a/arch/arm64/include/asm/dma-mapping.h > +++ b/arch/arm64/include/asm/dma-mapping.h > @@ -25,6 +25,7 @@ > > #define ARCH_HAS_DMA_GET_REQUIRED_MASK > > +#define DMA_ERROR_CODE (~0)
Hmm, is this guaranteed to be large enough for a dma_addr_t? Other 64-bit architectures using a non-zero error code cast to dma_addr_t before the negation.
Will
| |