lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/16] sched/wait: Collapse __wait_event macros -v5

* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:

> And it now builds, boots, and passes short rcutorture tests, updated
> patch below.
>
> One side-effect is the boot parameters, namely that what used to be
> rcutree.blimit=10 is now simply tree.blimit=10. Not a problem for me, I
> just made my test scripts probe the source tree and generate the
> corresponding format. But is there some straightforward way to get the
> name of the "rcu" directory involved? The obvious approach of
> "rcu.tree.blimit=10" does not work -- the kernel happily ignores any
> such parameter.

Hm, that boot option parser attitude is a bit sad - more structure to boot
parameters is IMHO a Good Thing.

Does it accept :

rcu/tree/blimit=10

rcu/tree.blimit=10

type of structure perhaps?

>
> It looks like I should be able to do something like the following in
> kernel/rcu/tree.c to get back the old parameter names:
>
> MODULE_ALIAS("rcutree");
> #ifdef MODULE_PARAM_PREFIX
> #undef MODULE_PARAM_PREFIX
> #endif
> #define MODULE_PARAM_PREFIX "rcutree."

Yeah.

( To keep it simple, the undef should be unnecessary, it's not like anyone
can slip in a MODULE_PARAM_PREFIX without you noticing, right? )

> And similarly for rcu/update.c and rcu/torture.c.
>
> In fact, it looks like I could make rcu/update.c also use either the
> "rcutree." or "rcutiny." prefix, depending on which was being built.
>
> Any thoughts, cautions, or suggestions?

Still looks nice to me!

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-10 10:41    [W:0.188 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site