lkml.org 
[lkml]   [2013]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is not enough ram for it
From
On Wed, Jan 9, 2013 at 1:00 PM, Eric W. Biederman <ebiederm@xmission.com> wrote:
> Yinghai Lu <yinghai@kernel.org> writes:
>
>> please check updated attached. It should address all your request.
>
> There is one significant bug that I can see.
>
> swiotlb_print_info tests no_iotlb_memory but no_iotlb_memory is set
> after swiotlb_init_with_tlb returns.

there is another swiotlb_print_info calling from
pci_swiotlb_late_init

void __init pci_swiotlb_late_init(void)
{
/* An IOMMU turned us off. */
if (!swiotlb)
swiotlb_free();
else {
printk(KERN_INFO "PCI-DMA: "
"Using software bounce buffering for IO (SWIOTLB)\n");
swiotlb_print_info();
}
}

so we need that checking when swiotlb == 1, but actually we can not
allocate that before.

Thanks

Yinghai


\
 
 \ /
  Last update: 2013-01-10 05:21    [W:0.304 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site