Messages in this thread | | | Date | Wed, 9 Jan 2013 11:26:59 -0800 (PST) | From | Hugh Dickins <> | Subject | Re: [PATCH] mm: migrate: Check page_count of THP before migrating accounting fix |
| |
On Wed, 9 Jan 2013, Mel Gorman wrote:
> As pointed out by Hugh Dickins, "mm: migrate: Check page_count of THP > before migrating" can leave nr_isolated_anon elevated, correct it. This > is a fix to mm-migrate-check-page_count-of-thp-before-migrating.patch > > Signed-off-by: Mel Gorman <mgorman@suse.de>
Thanks: to this and the one it's fixing (I expect akpm will merge)
Acked-by: Hugh Dickins <hughd@google.com>
> --- > mm/migrate.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index f466827..c387786 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1689,8 +1689,11 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm, > if (!isolated || page_count(page) != 2) { > count_vm_events(PGMIGRATE_FAIL, HPAGE_PMD_NR); > put_page(new_page); > - if (isolated) > + if (isolated) { > putback_lru_page(page); > + isolated = 0; > + goto out; > + } > goto out_keep_locked; > }
| |