[lkml]   [2013]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK
Digging back through the archives, this came up once in 2007, Alan Cox
did not like the idea of globally adding this call into the critical
paths of libata at the time. (I've seen it done via external patches
in ata_qc_issue and ata_qc_complete for example.) If that concern is
no longer in place, I can redo with it within libata so it'll work for
all libata driven devices similar to how it's handled for legacy IDE
drivers now.

Josh C

On Wed, Jan 9, 2013 at 11:56 AM, Jeff Garzik <> wrote:
> On 01/08/2013 01:16 PM, Joshua Coombs wrote:
>> Add a call to the IDE LED Trigger within the Marvell SATA driver to allow
>> Marvell SoC devices to show SATA activity via GPIO connected LEDs.
>> Signed-off-by: Joshua Coombs <>
>> ---
>> drivers/ata/sata_mv.c | 3 +++
>> drivers/leds/Kconfig | 3 +--
>> 2 files changed, 4 insertions(+), 2 deletions(-)
> NAK. This is not appropriate at the specific driver level. This would be
> better implemented at a higher level.

 \ /
  Last update: 2013-01-09 20:01    [W:0.052 / U:4.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site