lkml.org 
[lkml]   [2013]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 4/4] uretprobes: invoke return probe handlers
On 01/09, Anton Arapov wrote:
>
> static void handle_swbp(struct pt_regs *regs)
> {
> struct uprobe *uprobe;
> + struct xol_area *area;
> unsigned long bp_vaddr;
> int uninitialized_var(is_swbp);
>
> bp_vaddr = uprobe_get_swbp_addr(regs);
> - uprobe = find_active_uprobe(bp_vaddr, &is_swbp);
> + area = get_xol_area();

No, we do not need to allocate xol area here.

> + if (area) {
> + if (bp_vaddr == area->vaddr) {
> + handle_rp_swbp(regs);

Can't understand... this should check bp_vaddr == rp_trampoline_vaddr ?

Again, unless you remove rp_trampoline_vaddr altogether.

Oleg.



\
 
 \ /
  Last update: 2013-01-09 18:21    [W:0.074 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site