Messages in this thread | | | Date | Wed, 9 Jan 2013 17:28:42 +0100 | From | Oleg Nesterov <> | Subject | Re: [RFC PATCH v2 4/4] uretprobes: invoke return probe handlers |
| |
On 01/09, Anton Arapov wrote: > > static void handle_swbp(struct pt_regs *regs) > { > struct uprobe *uprobe; > + struct xol_area *area; > unsigned long bp_vaddr; > int uninitialized_var(is_swbp); > > bp_vaddr = uprobe_get_swbp_addr(regs); > - uprobe = find_active_uprobe(bp_vaddr, &is_swbp); > + area = get_xol_area();
No, we do not need to allocate xol area here.
> + if (area) { > + if (bp_vaddr == area->vaddr) { > + handle_rp_swbp(regs);
Can't understand... this should check bp_vaddr == rp_trampoline_vaddr ?
Again, unless you remove rp_trampoline_vaddr altogether.
Oleg.
| |