lkml.org 
[lkml]   [2013]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] pwm: atmel: add Timer Counter Block PWM driver
On 09/01/2013 08:46, Thierry Reding wrote:
> On Tue, Jan 08, 2013 at 04:36:42PM +0100, Boris BREZILLON wrote:
>> Hi,
>>
>> This patch adds a PWM driver based on Atmel Timer Counter Block.
>> Timer Counter Block is used in Waveform generator mode.
>>
>> A Timer Counter Block provides up to 6 PWM devices grouped by 2:
>> * group 0 = PWM 0 and 1
>> * group 1 = PWM 2 and 3
>> * group 2 = PMW 4 and 5
>>
>> PWM devices in a given group must be configured with the same
>> period value.
>> If a PWM device in a group tries to change the period value and
>> the other device is already configured with a different value an
>> error will be returned.
>>
>> This driver requires device tree support.
>> The Timer Counter Block number used to create a PWM chip is
>> given by tc-block field in an "atmel,tcb-pwm" compatible node.
>>
>> This patch was tested on kizbox board (at91sam9g20 SoC) with
>> pwm-leds.
>>
>> Regards,
>>
>> Boris
>>
>> Signed-off-by: Boris BREZILLON <linux-arm@overkiz.com>
>> ---
>> Changes since v1:
>> - Fix device tree binding Documentation
>> - Fix Kconfig issues (missing OF dependency,
>> deprecated HAVE_PWM select, ...)
>> - Fix various coding style issues.
>> - Cleanup code and add some comments.
>>
>> Changes since v2:
>> - Replace kzalloc/kfree with managed versions
>> (devm_kzalloc/devm_kfree).
>> - Add one cell to device tree binding to support polarity
>> flag.
>> - Replace min computation (2 div -> 1 mul + 1 div).
>>
>> Changes since v3:
>> - Fix device tree binding Documentation
>> - Fix Kconfig description
>> - Fix coding style issues (function parameters alignment)
>> - Replace 1000000000 value with NSEC_PER_SEC macro
>> - Get rid of newcmr variable in enable/disable functions
>> - Remove unneeded devm_kfree
>> - Add missing atmel_tc_free
>>
>> Changes since v4:
>> - Add missing comments
>> - Fix coding style issues (multi-line error string)
>> - Fix wrong MODULE_DEVICE_TABLE setting
>> - Remove unneeded MODULE_ALIAS declaration
>>
>> .../devicetree/bindings/pwm/atmel-tcb-pwm.txt | 18 +
>> drivers/pwm/Kconfig | 12 +
>> drivers/pwm/Makefile | 1 +
>> drivers/pwm/pwm-atmel-tcb.c | 445 ++++++++++++++++++++
>> 4 files changed, 476 insertions(+), 0 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt
>> create mode 100644 drivers/pwm/pwm-atmel-tcb.c
>
> Applied with minor changes to the commit message, thanks.
>
> Thierry
>

Thanks


\
 
 \ /
  Last update: 2013-01-09 12:41    [W:0.038 / U:1.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site