[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 07/12] VMCI: queue pairs implementation.
On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote:
> VMCI queue pairs allow for bi-directional ordered communication between host and guests.

You should wrap your commit lines at 72 characters, like git asks you to :)

> +/* Guest device port I/O. */
> +struct PPNSet {
> + u64 num_produce_pages;
> + u64 num_consume_pages;
> + u32 *produce_ppns;
> + u32 *consume_ppns;
> + bool initialized;
> +};

I know this is a private structure to the driver, so it's not that big
of a deal at all, but the naming for this is a bit odd (mixed case.)

Not a show stopper at all, but if you had run on it, it
would have warned you about this.


greg k-h

 \ /
  Last update: 2013-01-09 02:01    [W:0.058 / U:3.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site