[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: Commit 7032a3dd9 (svcrpc: demote some printks to a dprintk) adds warnings
On Tue, Jan 08, 2013 at 12:13:00PM +0000, Russell King wrote:
> Bruce,
> Your commit below causes a new build warning in the kernel:
> net/sunrpc/svc.c: In function 'svc_printk':
> net/sunrpc/svc.c:1050:7: warning: unused variable 'buf'
> which affects all ARM builds; it is the only warning in a lot of cases.
> Please can you resolve this new warning using whatever method you feel
> is most appropriate, thanks.

Bah, these "unused variable" warnings for buffers unused in the
!RPC_DEBUG case keep popping up.

I guess I'll commit the following for 3.9.


commit 31e815406973ef86e2e42a36086d65afb8f4e396
Author: J. Bruce Fields <>
Date: Tue Jan 8 16:22:15 2013 -0500

svcrpc: silence "unused variable" warning in !RPC_DEBUG case

Signed-off-by: J. Bruce Fields <>

diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index dbf12ac..b9ba2a8 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -1042,6 +1042,7 @@ static void svc_unregister(const struct svc_serv *serv, struct net *net)
* dprintk the given error with the address of the client that caused it.
+#ifdef RPC_DEBUG
static __printf(2, 3)
void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...)
@@ -1058,6 +1059,9 @@ void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...)

+static __printf(2,3) void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...) {}

* Common routine for processing the RPC request.

 \ /
  Last update: 2013-01-08 23:01    [W:0.015 / U:6.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site