Messages in this thread |  | | Date | Tue, 8 Jan 2013 18:58:22 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/7] uprobes: Move alloc_page() from xol_add_vma() to xol_alloc_area() |
| |
On 01/08, Srikar Dronamraju wrote: > > (One simple check below) > > Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Thanks,
> > @@ -1072,11 +1064,8 @@ static int xol_add_vma(struct xol_area *area) > > smp_wmb(); /* pairs with get_xol_area() */ > > mm->uprobes_state.xol_area = area; > > ret = 0; > > - > > -fail: > > + fail: > > Not sure if the space before label is intentional? > Its true of other labels below also.
Yes, this was intentional although almost subconscious.
Personally I prefer to add a space before the label, this helps /usr/bin/diff to not confuse this label with the function name.
But I can stop this if you dislike.
Oleg.
|  |