[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: 2nd attempt: help with dma_alloc_coherent() + dma_free_coherent()
On Tue, Jan 8, 2013 at 9:17 AM, Jeff Chua <> wrote:
> Interesting, but there are 54 lines under the kernel directories that
> use "dma_alloc_coherent(NULL," followed by "dma_free_coherent(NULL,"

As mentioned, it works on some platforms. That doesn't make it right.

> So, shouldn't they be fixed as well? ... unless they are so old that
> nobody cares anymore ...

Some of the ones I saw are in MIPS or blackfin. Others probably *are*
so old that nobody cares, and happen to work because there's iommu's
or other things that simply don't care about the device.

> # find . -exec grep -H "dma_alloc_coherent(NULL" {} \; | wc -l
> 54
> #find . -exec grep -H "dma_free_coherent(NULL" {} \; | wc -l
> 72

Let me tell you about "git grep", so that you never need to do that
disgusting "find -exec grep" ever again.

It does threading, it's fast, and it just works.


 \ /
  Last update: 2013-01-08 19:01    [W:0.036 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site