[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver
On Tue, Jan 08, 2013 at 04:21:59PM +0100, Boris BREZILLON wrote:
> Do I have to break the error string so that the line does not exceed 80
> characters ?


> Checkpath script does not complain about it, and the CodingStyle file
> specify that visible strings should not be broken...


> Same question applies to this error, which I converted to a multi-line
> error in a previous patch version:
> dev_err(chip->dev,
> "failed to configure period_ns:\n"
> "the other PWM device in this group is already\n"
> "configured with a different period_ns value\n");

Which is a bad idea. It appears in log files as multiple lines, which
makes parsing the error for analysis difficult (eg, you may have a
log analyser which tells you how many times an error occurs - the
above would be treated as three separate errors.

 \ /
  Last update: 2013-01-08 17:01    [W:0.036 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site