Messages in this thread |  | | Date | Tue, 08 Jan 2013 16:03:17 +0100 | From | "Ulrich Windl" <> | Subject | Antw: [PATCH 0/5] kfifo cleanup and log based kfifo API |
| |
>>> Yuanhan Liu <yuanhan.liu@linux.intel.com> schrieb am 08.01.2013 um 15:57 in Nachricht <1357657073-27352-1-git-send-email-yuanhan.liu@linux.intel.com>:
[...] > My proposal is to replace kfifo_init with kfifo_alloc, where it > allocate buffer and maintain fifo size inside kfifo. Then we can > remove buggy kfifo_init. [...]
Spontaneously I feel that emitting a critical message if the requested size is not a power of two would be a good idea, as well as (in that case) rounding up to the next power of two instead of rounding down seems not too stupid ;-)
Sorry, I'm not deeply into recent kernel development.
Regards, Ulrich
|  |