lkml.org 
[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/25] ab8500_charger: don't use [delayed_]work_pending()
From
On Sat, Dec 22, 2012 at 2:56 AM, Tejun Heo <tj@kernel.org> wrote:

> There's no need to test whether a (delayed) work item in pending
> before queueing, flushing or cancelling it. Most uses are unnecessary
> and quite a few of them are buggy.
>
> Remove unnecessary pending tests from ab8500_charger. Only compile
> tested.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>

Works like a charm for us, thanks!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Marcus Cooper <marcus.xm.cooper@stericsson.com>

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-01-08 16:21    [W:1.011 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site