Messages in this thread |  | | From | "Yang, Wenyou" <> | Subject | RE: [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support | Date | Tue, 8 Jan 2013 01:02:38 +0000 |
| |
> -----Original Message----- > From: Joe Perches [mailto:joe@perches.com] > Sent: 2013年1月7日 10:10 > To: Yang, Wenyou > Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Ferre, > Nicolas; plagnioj@jcrosoft.com; richard.genoud@gmail.com; Lin, JM; > grant.likely@secretlab.ca; spi-devel-general@lists.sourceforge.net > Subject: Re: [v3 PATCH 06/12] spi/atmel_spi: add dmaengine support > > On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote: > > From: Nicolas Ferre <nicolas.ferre@atmel.com> > [] > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > [] > > +static inline bool atmel_spi_use_dma(struct atmel_spi *as, > > + struct spi_transfer *xfer) > > +{ > > + if ((as->use_dma) && (xfer->len >= DMA_MIN_BYTES)) > > + return true; > > + else > > + return false; > > +} > > Same unnecessary form. > > return as->use_dma && xfer->len >= DMA_MIN_BYTES; > > > +static inline bool atmel_spi_use_pdc(struct atmel_spi *as) > > +{ > > + if (as->use_pdc) > > + return true; > > + else > > + return false; > > +} > > Does this function really need to exist at all? > Thanks a lot for your advice.
|  |