Messages in this thread |  | | From | H Hartley Sweeten <> | Date | Mon, 7 Jan 2013 16:50:55 -0600 | Subject | RE: [PATCH 2/2] Staging: comedi: addi_common.h: checkpatch.pl fixes |
| |
On Monday, January 07, 2013 3:40 PM, Greg KH wrote: > On Sat, Jan 05, 2013 at 06:12:55PM +0400, Lijo Antony wrote: >> Reduced line lengths to 80 chars by removing extra spaces. >> >> Signed-off-by: Lijo Antony <lijo.kernel@gmail.com> >> --- >> .../staging/comedi/drivers/addi-data/addi_common.h | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-)
<snip>
> As you didn't do this for all fields in the structure, it's not really > worth doing it for just these, right? > > The proper thing to do is use kerneldoc format and document it all at > the top of the structure, care to do that instead?
Hopefully I will soon get the rest of the addi-data drivers split off of the addi_common stuff. This will effectively remove this header file so I'm not sure it's worth making patches against it.
Regards, Hartley
|  |