lkml.org 
[lkml]   [2013]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is not enough ram for it
From
On Mon, Jan 7, 2013 at 12:32 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>> 2). The check for 1MB is suspect. Why only 1MB? You mentioned it is
>> b/c of crashkernel_low=72M (which I am not seeing in v3.8 kernel-parameters.txt?
>> Is that part of your mega-patchset?). Anyhow, there seems to be a disconnect -
>> what if the user supplied crashkernel_low=27M? Perhaps the 'is_enough'
>> should also parse the bootparams to double-check that there is enough
>> low-mem space? But then if the kernel grows then 72M might not be enough -
>> you might need 82M with 3.9.
>
> again, could with memmap= include or exclude case, so parse boot command line
> is not going to handle all the case.

replace the hardcoded 1M checking, please check attached -v3.

Thanks

Yinghai
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2013-01-07 23:21    [W:0.983 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site