Messages in this thread | | | Date | Mon, 7 Jan 2013 13:23:41 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH v2] mm: memblock: fix wrong memmove size in memblock_merge_regions() |
| |
On Mon, 7 Jan 2013 11:41:36 +0800 Lin Feng <linfeng@cn.fujitsu.com> wrote:
> The memmove span covers from (next+1) to the end of the array, and the index > of next is (i+1), so the index of (next+1) is (i+2). So the size of remaining > array elements is (type->cnt - (i + 2)).
What are the user-visible effects of this bug?
> --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -314,7 +314,8 @@ static void __init_memblock memblock_merge_regions(struct memblock_type *type) > } > > this->size += next->size; > - memmove(next, next + 1, (type->cnt - (i + 1)) * sizeof(*next)); > + /* move forward from next + 1, index of which is i + 2 */ > + memmove(next, next + 1, (type->cnt - (i + 2)) * sizeof(*next)); > type->cnt--; > } > } > -- > 1.7.11.7
| |