lkml.org 
[lkml]   [2013]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/i915: Treat crtc->mode.clock == 0 as disabled
On Mon, Jan 07, 2013 at 10:11:40AM +0000, Chris Wilson wrote:
> Prevent a divide-by-zero by consistently treating an 'active' CRTC
> without a mode set as actually disabled.
>
> This looks to have been first introduced with
>
> commit 24929352481f085c5f85d4d4cbc919ddf106d381
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Mon Jul 2 20:28:59 2012 +0200
>
> drm/i915: read out the modeset hw state at load and resume time
>
> but then combined with
>
> commit b0a2658acb5bf9ca86b4aab011b7106de3af0add
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Tue Dec 18 09:37:54 2012 +0100
>
> drm/i915: don't disable disconnected outputs
>
> it finally started oopsing.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reported-and-tested-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: stable@vger.kernel.org

Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


\
 
 \ /
  Last update: 2013-01-07 18:21    [W:0.050 / U:2.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site