lkml.org 
[lkml]   [2013]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] [media] coda: Fix build due to iram.h rename
From
Hi Sascha,

On Mon, Jan 7, 2013 at 8:03 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed the
> location of iram.h, which causes the following build error when building the coda
> driver:
>
> drivers/media/platform/coda.c:27:23: error: mach/iram.h: No such file or directory
> drivers/media/platform/coda.c: In function 'coda_probe':
> drivers/media/platform/coda.c:2000: error: implicit declaration of function 'iram_alloc'
> drivers/media/platform/coda.c:2001: warning: assignment makes pointer from integer without a cast
> drivers/media/platform/coda.c: In function 'coda_remove':
> drivers/media/platform/coda.c:2024: error: implicit declaration of function 'iram_free'
>
> Since the content of iram.h is not imx specific, move it to
> include/linux/platform_data/imx-iram.h instead. This is an intermediate solution
> until the i.MX iram allocator is converted to the generic SRAM allocator.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>
> Based on an earlier version from Fabio Estevam, but this one moves iram.h
> to include/linux/platform_data/imx-iram.h instead of include/linux/iram.h
> which is a less generic name.
>
> arch/arm/mach-imx/iram.h | 41 --------------------------------
> arch/arm/mach-imx/iram_alloc.c | 3 +--
> drivers/media/platform/coda.c | 2 +-
> include/linux/platform_data/imx-iram.h | 41 ++++++++++++++++++++++++++++++++
> 4 files changed, 43 insertions(+), 44 deletions(-)
> delete mode 100644 arch/arm/mach-imx/iram.h
> create mode 100644 include/linux/platform_data/imx-iram.h

It would be better to use git mv /git format-patch -M, so that git can
detect the file rename.

Regards,

Fabio Estevam


\
 
 \ /
  Last update: 2013-01-07 12:01    [W:0.364 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site