lkml.org 
[lkml]   [2013]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Fix test relying in wrong behavior of is_printable
From
Date
Err,

I can rework and resubmit to remove the comment, but the test doesn't fail:

> $ make check | grep 'MyBoardName.*-t s.*compatible'
> fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s label01.dts.fdtget.test.dtb / compatible: PASS
>

As of today's pull.

Regards

-- Pantelis

On Jan 7, 2013, at 12:14 AM, Jon Loeliger wrote:

>> Hi David
>>
>> =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85
>>
>> 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson <david@gibson.dr=
>> opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5:
>>
>>> On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
>>>> After fixing the is_printable bug the test suite fails.
>>>> Fix it with this patch
>>>> =20
>>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>>> =20
>>> Rather than just removing the test, it would be better to still run it
>>> using an explicit -t bi to force the byte output.
>>
>> Perhaps it wasn't exactly clear in the patch. The old test case output is co=
>> mmented out but there is test case output for the new patch.=20
>>
>> So the test is not removed.=20
>
> Uh, yeah, something needs to be done here still.
> (There is a failing test still.)
>
> Could we get a resubmission of the fix, please?
>
> Thanks,
> jdl



\
 
 \ /
  Last update: 2013-01-07 11:42    [W:0.192 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site