Messages in this thread |  | | Subject | Re: Fix test relying in wrong behavior of is_printable | From | Pantelis Antoniou <> | Date | Mon, 7 Jan 2013 11:55:32 +0200 |
| |
Err,
I can rework and resubmit to remove the comment, but the test doesn't fail:
> $ make check | grep 'MyBoardName.*-t s.*compatible' > fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s label01.dts.fdtget.test.dtb / compatible: PASS >
As of today's pull.
Regards
-- Pantelis
On Jan 7, 2013, at 12:14 AM, Jon Loeliger wrote:
>> Hi David >> >> =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85 >> >> 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson <david@gibson.dr= >> opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: >> >>> On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: >>>> After fixing the is_printable bug the test suite fails. >>>> Fix it with this patch >>>> =20 >>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com> >>> =20 >>> Rather than just removing the test, it would be better to still run it >>> using an explicit -t bi to force the byte output. >> >> Perhaps it wasn't exactly clear in the patch. The old test case output is co= >> mmented out but there is test case output for the new patch.=20 >> >> So the test is not removed.=20 > > Uh, yeah, something needs to be done here still. > (There is a failing test still.) > > Could we get a resubmission of the fix, please? > > Thanks, > jdl
|  |