Messages in this thread |  | | Date | Sun, 6 Jan 2013 21:27:11 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH] dma: tegra: add support for Tegra114 SoC |
| |
On Sunday 06 January 2013 08:07 PM, Vinod Koul wrote: > On Sat, Jan 05, 2013 at 05:36:08PM +0530, Laxman Dewangan wrote: >> NVIDIA's Tegra114 has APB DMA controller which supports channel wise >> pause control. The global pause is used for clock gating and hence >> DMA registers are not accessible if DMAs are globally disabled. >> >> Add support for use of channel wise pause feature for Tegra114 SOCs. > Looks fine to me. Only issue being that changelog tells me you are adding > support for 114, but patch seems more of adding pause support and while at it > also add entries for 114. > Care to update changelog & title...
The channel wise pause come along with T114 and that's why it is together in this change. Probably I need to split the change into two patches: One for adding feature of channel wise pause and other for adding support of T114. This way it will not mixup the stuff and will much clear about change.
|  |