[lkml]   [2013]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] fb: udlfb: fix scheduling while atomic.
Am 05.01.2013 12:42, schrieb Alexander Holler:
> The console functions are using spinlocks while calling fb-driver ops
> but udlfb waits for a semaphore in many ops. This results in the BUG
> "scheduling while atomic". One of those call flows is e.g.
> vt_console_print() (spinlock printing_lock)
> (...)
> dlfb_ops_imageblit()
> dlfb_handle_damage()
> dlfb_get_urb()
> down_timeout(semaphore)
> BUG: scheduling while atomic
> (...)
> vt_console_print() (release spinlock printing_lock)
> Fix this through a workqueue for dlfb_handle_damage().
> Cc: <>
> Signed-off-by: Alexander Holler <>

Having had a second look at my patch for udlfb, I'm not sure it will
work with more than one of those devices attached. I think my approach
to just add one (static) workqueue might not work in such a case, at
least it looks so to me. But I'm unable to test it, as I only have one
of those devices.

Having had a look at udl, I wonder why udlfb still has to be around. But
because udl currently doesn't work here too, I'm not sure what
functionality udl misses which udlfb still has.

So to conclude, my patch works as a workaround if only one of those
devices will be attached, but currently should not be included into the

I don't know if I will make another version of that patch, as I will
first have a deeper look at udl (if I find the time).



 \ /
  Last update: 2013-01-06 14:21    [W:0.097 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site