lkml.org 
[lkml]   [2013]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] iio: lp8788_adc: fix a parent device in _probe()
On 01/03/2013 06:28 AM, Kim, Milo wrote:
> The lp8788-adc is a platform driver of lp8788-mfd.
> The platform device is allocated when mfd_add_devices() is called
> in lp8788-mfd.
> On the other hand, 'lp->dev' is the i2c client device.
>
> Therefore, this 'platform_device' is a proper parent device of
> iio device and device kernel message.

Added to togreg branch of iio.git

Thanks,
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/iio/adc/lp8788_adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/lp8788_adc.c b/drivers/iio/adc/lp8788_adc.c
> index 72955e4..4c9b0f7 100644
> --- a/drivers/iio/adc/lp8788_adc.c
> +++ b/drivers/iio/adc/lp8788_adc.c
> @@ -214,7 +214,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
>
> mutex_init(&adc->lock);
>
> - indio_dev->dev.parent = lp->dev;
> + indio_dev->dev.parent = &pdev->dev;
> indio_dev->name = pdev->name;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->info = &lp8788_adc_info;
> @@ -223,7 +223,7 @@ static int lp8788_adc_probe(struct platform_device *pdev)
>
> ret = iio_device_register(indio_dev);
> if (ret) {
> - dev_err(lp->dev, "iio dev register err: %d\n", ret);
> + dev_err(&pdev->dev, "iio dev register err: %d\n", ret);
> goto err_iio_device;
> }
>
>


\
 
 \ /
  Last update: 2013-01-06 13:01    [W:1.096 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site