lkml.org 
[lkml]   [2013]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fix test relying in wrong behavior of is_printable
On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
> After fixing the is_printable bug the test suite fails.
> Fix it with this patch
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>

Rather than just removing the test, it would be better to still run it
using an explicit -t bi to force the byte output.

> ---
> tests/run_tests.sh | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index dd7f217..43279c9 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -498,9 +498,8 @@ fdtget_tests () {
>
> # run_fdtget_test <expected-result> [<flags>] <file> <node> <property>
> run_fdtget_test "MyBoardName" $dtb / model
> - run_fdtget_test "77 121 66 111 \
> -97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 \
> -108 121 78 97 109 101 0" $dtb / compatible
> + # run_fdtget_test "77 121 66 111 97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 108 121 78 97 109 101 0" $dtb / compatible
> + run_fdtget_test "MyBoardName MyBoardFamilyName" $dtb / compatible
> run_fdtget_test "MyBoardName MyBoardFamilyName" -t s $dtb / compatible
> run_fdtget_test 32768 $dtb /cpus/PowerPC,970@1 d-cache-size
> run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-01-06 08:41    [W:0.662 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site