lkml.org 
[lkml]   [2013]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] modpost: Add flag -f for making section mismatches fatal
On Sun, Jan 6, 2013 at 4:36 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Jonathan.
>
>> The section mismatch warning can be easy to miss during the kernel build
>> process. Allow it to be marked as fatal to be easily caught and prevent
>> bugs from slipping in.
>>
>> Signed-off-by: Jonathan Kliegman <kliegs@chromium.org>
>
> Another way to make them much more visible would be to make
> the warnings always be verbose.

I'd like to keep the option for a hard fail if a mismatch is detected.
This way automated build systems will detect the failed build and can
reject a chan

> In other words drop support for the "-S" options used below:
>> $(if $(CONFIG_DEBUG_SECTION_MISMATCH),,-S)
>
> Previously the dev* stuff caused a lot of warnings, but
> since we have HOTPLUG always enabled this is a non-issue.
> So I think that this is a good time to enable the verboce
> warnings.
I can submit a second patch for this if you'd like, but I'm not
familiar with all the previous decisions in this area. If I
understand correctly we'll still need the config option as it also
changes compiler flags for inlining.
>
> Sam


\
 
 \ /
  Last update: 2013-01-06 22:01    [W:0.078 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site