Messages in this thread | | | Date | Sat, 5 Jan 2013 14:11:15 -0800 | From | Anton Vorontsov <> | Subject | Re: [PATCH 01/25] charger_manager: don't use [delayed_]work_pending() |
| |
On Fri, Dec 21, 2012 at 05:56:51PM -0800, Tejun Heo wrote: > There's no need to test whether a (delayed) work item in pending > before queueing, flushing or cancelling it. Most uses are unnecessary > and quite a few of them are buggy. > > Remove unnecessary pending tests and rewrite _setup_polling() so that > it uses mod_delayed_work() if the next polling interval is sooner than > currently scheduled. queue_delayed_work() is used otherwise. > > Only compile tested. I noticed that two work items - setup_polling > and cm_monitor_work - schedule each other. It's a very unusual > construct and I'm fairly sure it's racy. You can't break such > circular dependency by calling cancel on each. I strongly recommend > revising the mechanism. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Anton Vorontsov <cbou@mail.ru> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: Donggeun Kim <dg77.kim@samsung.com> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com> > --- > Please let me know how this patch should be routed. I can take it > through the workqueue tree if necessary.
Charger manager is a fast moving target, so it is prone to conflict; it is better if I take it via battery-2.6.git tree. It is merged, thanks a lot!
Anton
| |