lkml.org 
[lkml]   [2013]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is not enough ram for it
    From
    On Fri, Jan 4, 2013 at 9:10 PM, Yinghai Lu <yinghai@kernel.org> wrote:
    > On Fri, Jan 4, 2013 at 6:02 PM, Shuah Khan <shuahkhan@gmail.com> wrote:
    >> I applied your patch to 3.6.11 and changed the panic() to pr_info()
    >> and also changed enough_mem_for_swiotlb() to always return false to
    >> simulate not enough memory condition as this system does have enough
    >> memory.
    >>
    >> So at least on this AMD system, your patch will result in a panic.
    >
    > ok, thanks for testing.
    >
    > if enough_mem_for_swiotlb() return false really, allocating buffer
    > for swiotlb with bootmem would panic already, right?
    >
    > so this patch just delay the panic a while for AMD system with
    > unhandled devices by IOMMU.
    >
    > Thanks
    >
    > Yinghai

    Right. It will eventually panic. I think this is not a valid test. I
    am planning to run more tests without forcing no memory condition
    which is what I should have done in the first place. I will let you
    know what I find, very likely Monday.

    Thanks,
    -- Shuah


    \
     
     \ /
      Last update: 2013-01-05 23:21    [W:5.275 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site