Messages in this thread | | | Date | Sat, 5 Jan 2013 23:49:36 +1100 | From | David Gibson <> | Subject | Re: Fix util_is_printable_string |
| |
On Fri, Jan 04, 2013 at 09:12:58PM +0200, Pantelis Antoniou wrote: > The method used did not account for multi-part strings. > > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
I think it could do with some more commenting of exactly what it's considering a printable string(s). I'm pretty sure it's doing the right thing, but if you're not already familiar with the OF multi-string convention, it would be easy to get confused by the code. Other than that
Acked-by: David Gibson <david@gibson.dropbear.id.au>
-- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [unhandled content-type:application/pgp-signature] | |