Messages in this thread | | | Date | Fri, 4 Jan 2013 16:12:05 -0500 | From | "J. Bruce Fields" <> | Subject | Re: [PATCH] nfsd: Remove write permission from file content |
| |
On Fri, Jan 04, 2013 at 07:45:35PM +0800, ycnian@gmail.com wrote: > From: Yanchuan Nian <ycnian@gmail.com> > > The write function doesn't be implemented in file content, and it's meaningless > to write data into this file directly. Remove write permission from it.
So does it really matter either way?
OK, applying, but I wonder.
--b.
> > Signed-off-by: Yanchuan Nian <ycnian@gmail.com> > --- > net/sunrpc/cache.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c > index 9afa439..9f84703 100644 > --- a/net/sunrpc/cache.c > +++ b/net/sunrpc/cache.c > @@ -1614,7 +1614,7 @@ static int create_cache_proc_entries(struct cache_detail *cd, struct net *net) > goto out_nomem; > } > if (cd->cache_show) { > - p = proc_create_data("content", S_IFREG|S_IRUSR|S_IWUSR, > + p = proc_create_data("content", S_IFREG|S_IRUSR, > cd->u.procfs.proc_ent, > &content_file_operations_procfs, cd); > cd->u.procfs.content_ent = p; > -- > 1.7.4.4 >
| |