Messages in this thread | | | Date | Fri, 04 Jan 2013 12:52:45 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH 4/4] input: keyboard: tegra: remove default key mapping |
| |
On 01/04/2013 04:02 AM, Laxman Dewangan wrote: > Tegra KBC driver have the default key mapping for 16x8 configuration. > The key mapping can be provided through platform data or through DT > and the mapping varies from platform to platform, hence this default > mapping is not so useful. Remove the default mapping to reduce the code > lines of the driver.
Overall, I agree with the intent of this change, but I /think/ the default keymap described here actually /is/ useful for the Seaboard/Springbank platforms. I guess the KBC driver isn't in the device tree for that (or any) board yet, so removing this keymap isn't really a regression, but it would be nice if you could come up with a change to add suitable keymaps to the device tree files too.
| |