Messages in this thread | | | Date | Thu, 31 Jan 2013 14:01:31 -0800 | Subject | Re: [RFC][PATCH] rip out x86_32 NUMA remapping code | From | Yinghai Lu <> |
| |
On Thu, Jan 31, 2013 at 1:59 PM, H. Peter Anvin <hpa@zytor.com> wrote: > On 01/31/2013 01:55 PM, Yinghai Lu wrote: >> On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin <hpa@zytor.com> wrote: >>> I get a build failure on i386 allyesconfig with this patch: >>> >>> arch/x86/power/built-in.o: In function `swsusp_arch_resume': >>> (.text+0x14e4): undefined reference to `resume_map_numa_kva' >>> >>> It looks trivial to fix up; I assume resume_map_numa_kva() just goes >>> away like it does in the non-NUMA case, but it would be nice if you >>> could confirm that. >> >> the patches does not seem to complete. >> >> at least, it does not remove >> >> arch/x86/mm/numa.c: nd = alloc_remap(nid, nd_size); >> > > ... which will just return NULL because alloc_remap turns into an inline > just returning NULL. So the compiled code is correct, but the source > code is needlessly messy.
yes...
It still left #ifdefCONFIG_HAVE_ARCH_ALLOC_REMAP there.
#ifdef CONFIG_HAVE_ARCH_ALLOC_REMAP extern void *alloc_remap(int nid, unsigned long size); #else static inline void *alloc_remap(int nid, unsigned long size) { return NULL; } #endif /* CONFIG_HAVE_ARCH_ALLOC_REMAP */
should throw them all away.
| |