Messages in this thread | | | Date | Fri, 1 Feb 2013 11:57:30 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 3/4] Export blk_fill_rwbs() |
| |
on 2013/2/1 11:48, Steven Rostedt wrote: > Li, > > Can you give an Ack or Nack for this. >
I think this patch shouldn't go into upstream without bcache code. We don't export symbols for out of tree code.
> Thanks, > > -- Steve > > > On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote: >> Exported so it can be used by bcache's tracepoints >> >> Signed-off-by: Kent Overstreet <koverstreet@google.com> >> CC: Steven Rostedt <rostedt@goodmis.org> >> CC: Frederic Weisbecker <fweisbec@gmail.com> >> CC: Ingo Molnar <mingo@redhat.com> >> --- >> kernel/trace/blktrace.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c >> index c0bd030..dbe1667 100644 >> --- a/kernel/trace/blktrace.c >> +++ b/kernel/trace/blktrace.c >> @@ -1806,6 +1806,7 @@ void blk_fill_rwbs(char *rwbs, u32 rw, int bytes) >> >> rwbs[i] = '\0'; >> } >> +EXPORT_SYMBOL_GPL(blk_fill_rwbs); >> >> #endif /* CONFIG_EVENT_TRACING */ >> > > >
| |