Messages in this thread | | | Date | Fri, 1 Feb 2013 11:28:02 +0800 | Subject | Re: [PATCH] block: partition: optimize memory allocation in check_partition | From | Ming Lei <> |
| |
On Fri, Feb 1, 2013 at 11:20 AM, Joe Perches <joe@perches.com> wrote: >> @@ -15,13 +15,15 @@ struct parsed_partitions { >> int flags; >> bool has_info; >> struct partition_meta_info info; >> - } parts[DISK_MAX_PARTS]; >> + } *parts; > > This is relatively unusual style. > Could you break out this struct instead?
IMO, looks it isn't necessary since no one uses the type of the embedded structure directly, and the style isn't introduced by this patch, which only follows the previous one.
Thanks, -- Ming Lei
| |