lkml.org 
[lkml]   [2013]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] block: partition: optimize memory allocation in check_partition
From
On Fri, Feb 1, 2013 at 11:20 AM, Joe Perches <joe@perches.com> wrote:
>> @@ -15,13 +15,15 @@ struct parsed_partitions {
>> int flags;
>> bool has_info;
>> struct partition_meta_info info;
>> - } parts[DISK_MAX_PARTS];
>> + } *parts;
>
> This is relatively unusual style.
> Could you break out this struct instead?

IMO, looks it isn't necessary since no one uses the type of the embedded
structure directly, and the style isn't introduced by this patch, which only
follows the previous one.

Thanks,
--
Ming Lei


\
 
 \ /
  Last update: 2013-02-01 04:41    [W:0.040 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site