Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH] perf tools: fix set event list leader | Date | Fri, 01 Feb 2013 10:50:44 +0900 |
| |
Hi Stephane,
On Thu, 31 Jan 2013 13:54:37 +0100, Stephane Eranian wrote: > The __perf_evlist__set_leader() was setting the leader for all events > in the list except the first. Which means it assumed the first event > already had event->leader = event. Seems like this should be the role > of the function to also do this. This is a requirement for an upcoming > patch set. > > Signed-off-by: Stephane Eranian <eranian@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
> --- > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index dc8aee9..050d5bc 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -119,8 +119,7 @@ void __perf_evlist__set_leader(struct list_head *list) > leader = list_entry(list->next, struct perf_evsel, node); > > list_for_each_entry(evsel, list, node) { > - if (evsel != leader) > - evsel->leader = leader; > + evsel->leader = leader; > } > } >
| |