| Date | Thu, 31 Jan 2013 17:03:47 -0500 | From | Aristeu Rozanski <> | Subject | Re: [PATCH v4 9/9] devcg: propagate local changes down the hierarchy |
| |
Hi Serge, On Thu, Jan 31, 2013 at 04:38:39AM +0000, Serge E. Hallyn wrote: > > @@ -610,9 +770,14 @@ case '\0': > > */ > > if (devcgroup->behavior == DEVCG_DEFAULT_ALLOW) { > > dev_exception_rm(devcgroup, &ex); > > - return 0; > > + rc = propagate_exception(devcgroup); > > Let's say the default in both parent A and child B is ALLOW, and both > have a blacklist entry for "b 8:* rwm". Now I > > echo "b 8:* rwm" > A/devices.allow > > removing the blacklist entry. Here you are propagating that to the > child B, which I would argue is actually propagating a new allow to > a child. Which you said you wouldn't do.
yep, that's a bug. will fix it up
thanks!
-- Aristeu
|