lkml.org 
[lkml]   [2013]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v4 9/9] devcg: propagate local changes down the hierarchy
Hi Serge,
On Thu, Jan 31, 2013 at 04:38:39AM +0000, Serge E. Hallyn wrote:
> > @@ -610,9 +770,14 @@ case '\0':
> > */
> > if (devcgroup->behavior == DEVCG_DEFAULT_ALLOW) {
> > dev_exception_rm(devcgroup, &ex);
> > - return 0;
> > + rc = propagate_exception(devcgroup);
>
> Let's say the default in both parent A and child B is ALLOW, and both
> have a blacklist entry for "b 8:* rwm". Now I
>
> echo "b 8:* rwm" > A/devices.allow
>
> removing the blacklist entry. Here you are propagating that to the
> child B, which I would argue is actually propagating a new allow to
> a child. Which you said you wouldn't do.

yep, that's a bug. will fix it up

thanks!

--
Aristeu



\
 
 \ /
  Last update: 2013-02-01 00:02    [W:0.219 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site