Messages in this thread | | | Date | Thu, 31 Jan 2013 13:27:06 -0800 | From | Andrew Morton <> | Subject | Re: resend----[PATCH] Avoid high order memory allocating with kmalloc, when read large seq file |
| |
On Thu, 31 Jan 2013 14:11:32 +0800 xtu4 <xiaobing.tu@intel.com> wrote:
> [SEQ_FILE] Avoid high order memory allocating with kmalloc > when read large seq file
The patch is still horridly mangled by your email client.
The implementation cheerfully ignores my earlier comment: "The conventional way of doing this is to attempt the kmalloc with __GFP_NOWARN and if that failed, fall back to vmalloc()."
This code has existed for ten years and this is the first time anyone has encountered this problem. Rather than mucking around with the seq_file code to attempt to fix this, it would be better to fix the calling code.
| |