lkml.org 
[lkml]   [2013]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: resend----[PATCH] Avoid high order memory allocating with kmalloc, when read large seq file
On Thu, 31 Jan 2013 14:11:32 +0800
xtu4 <xiaobing.tu@intel.com> wrote:

> [SEQ_FILE] Avoid high order memory allocating with kmalloc
> when read large seq file

The patch is still horridly mangled by your email client.

The implementation cheerfully ignores my earlier comment: "The
conventional way of doing this is to attempt the kmalloc with
__GFP_NOWARN and if that failed, fall back to vmalloc()."

This code has existed for ten years and this is the first time anyone
has encountered this problem. Rather than mucking around with the
seq_file code to attempt to fix this, it would be better to fix the
calling code.


\
 
 \ /
  Last update: 2013-01-31 23:02    [W:0.057 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site