Messages in this thread | | | Date | Thu, 31 Jan 2013 19:44:49 +0100 | From | Fabio Baltieri <> | Subject | Re: [PATCH 1/2] cpufreq: governors: Get rid of dbs_data->enable field |
| |
On Thu, Jan 31, 2013 at 10:58:01PM +0530, Viresh Kumar wrote: > CPUFREQ_GOV_START/STOP are called only once for all policy->cpus and hence we > don't need to adapt cpufreq_governor_dbs() routine for multiple calls. > > So, this patch removes dbs_data->enable field entirely. And rearrange code a > bit. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Hi Fabio, > > I have fixed all the pending issues, but haven't checked these patches. Can you > please add your tested-by (obviously after testing them) ? > > Compile tested only.
Hello Viresh, thanks for getting this done... looks much cleaner now!
I tested both patches on my ux500 setup (dual Cortex-A9) and it seems to run correctly on both CPU load changes and CPU hotplug, so:
Tested-by: Fabio Baltieri <fabio.baltieri@linaro.org>
As a sidenote, I noticed just now that since:
bc92bea cpufreq: Notify governors when cpus are hot-[un]plugged
governor's sampling_rate gets reset to default every time you hotplug a CPU (the one you read/write on /sys/devices/system/cpu/cpufreq/ondemand/sampling_rate).
If you need further tests, I'll be back on Monday.
Thanks, Fabio
-- Fabio Baltieri
| |