lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] digsig: Fix memory leakage in digsig_verify_rsa()
What's the practical impact of this?  Could an attacker kill the machine?


On Wed, 30 Jan 2013, Kasatkin, Dmitry wrote:

> On Fri, Jan 25, 2013 at 4:54 PM, Dmitry Kasatkin
> <dmitry.kasatkin@intel.com> wrote:
> > From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> >
> > digsig_verify_rsa() does not free kmalloc'ed buffer returned by
> > mpi_get_buffer().
> >
> > Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> > Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
> > Cc: stable@vger.kernel.org
> > ---
> > lib/digsig.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/digsig.c b/lib/digsig.c
> > index 8c0e629..dc2be7e 100644
> > --- a/lib/digsig.c
> > +++ b/lib/digsig.c
> > @@ -162,6 +162,8 @@ static int digsig_verify_rsa(struct key *key,
> > memset(out1, 0, head);
> > memcpy(out1 + head, p, l);
> >
> > + kfree(p);
> > +
> > err = pkcs_1_v1_5_decode_emsa(out1, len, mblen, out2, &len);
> > if (err)
> > goto err;
> > --
> > 1.7.10.4
> >
>
> James, can you please apply this patch.
>
> - Dmitry
>

--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2013-01-31 02:21    [W:0.045 / U:1.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site