lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] f2fs: avoid redundant call to has_not_enough_free_secs in f2fs_gc
From
Date
2013-01-30 (수), 22:47 +0900, Namjae Jeon:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> After doing a write_checkpoint from garbage collection path if there is still
> need to do more garbage collection, gc_more label is used to jump and start
> the process again. And in that process, first step before getting victim is to
> check if there are not enough free sections, which is already done before
> doing a jump to gc_more. We can avoid the redundant call to check free
> sections, by checking the gc_type flag which will remain FG_GC(value 1) under
> this condition.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
> fs/f2fs/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 9b5d0aa..0dfdaa5 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -672,7 +672,7 @@ gc_more:
> if (!(sbi->sb->s_flags & MS_ACTIVE))
> goto stop;
>
> - if (has_not_enough_free_secs(sbi))
> + if (!gc_type && has_not_enough_free_secs(sbi))

I applied this patch with the following change:
if (gc_type == BG_GC && has_not_enough_free_secs(sbi))

Thank you. :)

> gc_type = FG_GC;
>
> if (!__get_victim(sbi, &segno, gc_type, NO_CHECK_TYPE))

--
Jaegeuk Kim
Samsung
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-01-31 02:21    [W:0.173 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site