Messages in this thread |  | | Date | Wed, 30 Jan 2013 16:42:20 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 1/3] mm: use long type for page counts in mm_populate() and get_user_pages() |
| |
On Wed, 30 Jan 2013 16:26:18 -0800 Michel Lespinasse <walken@google.com> wrote:
> Use long type for page counts in mm_populate() so as to avoid integer > overflow
Would prefer to use unsigned long if we're churning this code. A "page count" can never be negative and we avoid the various possible overflow/signedness issues.
However get_user_pages() and follow_hugetlb_page() return "page count or -ve errno", so we're somewhat screwed there. And that's the bulk of the patch :(
btw, what twit merged a follow_hugetlb_page() which takes an undocumented argument called "i". Sigh.
|  |