lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] firewire: Fix ohci free_irq() warning
On 29 January 2013 17:01, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Tue, 29 Jan 2013, Stefan Richter wrote:
>
>> Added Cc: linux-pm.
>>
>> On Jan 29 Mark Einon wrote:
>> > On 28 January 2013 23:01, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>> > > On Jan 28 Mark Einon wrote:
>> > >> This patch fixes the kernel warning generated when putting an MSI MS-1727
>> > >> GT740 laptop into suspend mode. The call sequence in this case calls
>> > >> free_irq() twice, once in pci_remove() and once then in pci_suspend().
>> > >
>> > > You mean /first/ in pci_suspend() and /then/ in pci_remove() on the
>> > > already suspended devices, right?
>> >
>> > Yes, I did. The call sequence is suspend then resume. My bad.
>
> Why does the pci_suspend routine call free_irq() at all? As far as I
> know, it's not supposed to do that. Won't the device continue to use
> the same IRQ after it is resumed?

This sounds reasonable to me - I think we could probably get rid of
the request_irq() call from resume, and use
disable_irq()/enable_irq()?
I'll attempt a patch - but unfortunately I don't have a firewire device to test.

Cheers,

Mark


\
 
 \ /
  Last update: 2013-01-31 01:41    [W:2.598 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site