lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/11] staging/fwserial: Fix premature unthrottle
On Wed, Jan 30, 2013 at 08:37:23AM -0500, Peter Hurley wrote:
> On Wed, 2013-01-30 at 14:32 +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 30, 2013 at 08:11:05AM -0500, Peter Hurley wrote:
> > > On Tue, 2013-01-29 at 23:29 -0500, Greg Kroah-Hartman wrote:
> > > > On Mon, Jan 28, 2013 at 10:34:44PM -0500, Peter Hurley wrote:
> > > > > The unthrottle may restart the writer before the rx push
> > > > > has a chance to start emptying the rx buffer, resulting in an
> > > > > overflowed rx buffer and lost data.
> > > > >
> > > > > Perform the actual device unthrottle with the rx push instead.
> > > > >
> > > > > Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> > > > > ---
> > > > > drivers/staging/fwserial/fwserial.c | 30 ++++++++++++++----------------
> > > > > 1 file changed, 14 insertions(+), 16 deletions(-)
> > > >
> > > > this patch fails to apply to my tree, but the 9 previous ones were fine,
> > > > so I'll not apply it, or ght 11/11 patch. Care to fix it up and resend
> > > > both of them?
> > >
> > > Hi Greg,
> > >
> > > I can rebase these against your staging-next, if you'd prefer, but it
> > > will make the -next merge non-trivial.
> > >
> > > Your tty-next tree is carrying patches to this driver from patch series
> > > "TTY: switch flipping functions to tty_port"
> > > which is already in -next.
> > >
> > > Let me know what you'd like me to do.
> >
> > Ugh, that's a mess.
> >
> > Can these wait until after 3.9-rc1 is out?
>
> Ok. Should I plan to resend patches 10 & 11 then (as 1 & 2)?

Yes, please do.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-01-30 18:01    [W:0.173 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site